Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Import Functionality #5

Closed
3 tasks done
PhilMFischer opened this issue Aug 7, 2019 · 0 comments · Fixed by #17
Closed
3 tasks done

Implement Import Functionality #5

PhilMFischer opened this issue Aug 7, 2019 · 0 comments · Fixed by #17
Assignees
@PhilMFischer
Labels
feature New feature or request
Milestone
Relese_0.1.0_Beta

Comments

@PhilMFischer
Copy link
Member

PhilMFischer commented Aug 7, 2019 •
edited by ghost
Loading

  • Add an import dialog to select a propper json
  • Add import functionality for initial import from json
  • Add functionality for recurring import from json to update the design
@PhilMFischer PhilMFischer added the feature New feature or request label Aug 7, 2019
@PhilMFischer PhilMFischer self-assigned this Aug 7, 2019
PhilMFischer added a commit that referenced this issue Aug 7, 2019
@PhilMFischer
Just ignoring some new files - (Task #5)
b3a086f 
- Added log file to gitignore

---
Task #5: Implement Import Functionality
PhilMFischer added a commit that referenced this issue Aug 7, 2019
@PhilMFischer
Added first implementations for commands - (Task #5)
ec36320 
- Added import export commands
- Bound them to gui
- Added icons

---
Task #5: Implement Import Functionality
PhilMFischer added a commit that referenced this issue Aug 8, 2019
@PhilMFischer
Implemented first generation of a box part - (Task #5)
059f868 
- Added code to import a box from a json object
- Added test code framework

---
Task #5: Implement Import Functionality
PhilMFischer added a commit that referenced this issue Aug 8, 2019
@PhilMFischer
Improved code and test cases- (Task #5)
ea6cb50 
- Added test case for part creation
- Implemented parser for parts stored in json
- Added test case for parser as well

---
Task #5: Implement Import Functionality
PhilMFischer added a commit that referenced this issue Aug 8, 2019
@PhilMFischer
Fixed flake warnings- (Task #5)
ee2ae64 
- Fixed due to debug output on travis ci

---
Task #5: Implement Import Functionality
PhilMFischer added a commit that referenced this issue Aug 8, 2019
@PhilMFischer
Fixed Systax error - (Task #5)
98e7a22 
- removed incorrect forward declaration of variable

---
Task #5: Implement Import Functionality
PhilMFischer added a commit that referenced this issue Aug 8, 2019
@PhilMFischer
Improved test cases and part creation - (Task #5)
96d9417 
- fixed issue with updating part not reusing existing file.
- improved test cases which now clean workspace before execution.

---
Task #5: Implement Import Functionality
PhilMFischer added a commit that referenced this issue Aug 8, 2019
@PhilMFischer
Added spreadsheet to parts - (Task #5)
1b7c90f 
- Added spreadsheet to store data from Virtual Satellite

---
Task #5: Implement Import Functionality
PhilMFischer added a commit that referenced this issue Aug 12, 2019
@PhilMFischer
Removed future import to long - (Task #5)
cf0013d 
- Replacing long usage with integer.

---
Task #5: Implement Import Functionality
PhilMFischer added a commit that referenced this issue Aug 12, 2019
@PhilMFischer
Added new factory for creating correct part object - (Task #5)
c8dd6a0 
- Created part object factory
- Created classes for objects that can be created by factory

---
Task #5: Implement Import Functionality
PhilMFischer added a commit that referenced this issue Aug 12, 2019
@PhilMFischer
major refactoring - (Task #5)
700d830 
- changed creation of test directories. test directories are now created
in a separate class.

---
Task #5: Implement Import Functionality
PhilMFischer added a commit that referenced this issue Aug 12, 2019
@PhilMFischer
Got some tests running again - (Task #5)
0552522 
Put your Message here.

---
Task #5: Implement Import Functionality
PhilMFischer added a commit that referenced this issue Aug 14, 2019
@PhilMFischer
Implemented the part to sheet io - (Task #5)
a4cf426 
- can now write part properties to excel sheet
- can also read properties back from sheet
- implemented test cases

---
Task #5: Implement Import Functionality
PhilMFischer added a commit that referenced this issue Aug 14, 2019
@PhilMFischer
Implemented first version of box part object - (Task #5)
c6df50e 
also refactored some of the code such as Active Document to be more
handy.

---
Task #5: Implement Import Functionality
PhilMFischer added a commit that referenced this issue Aug 14, 2019
@PhilMFischer
Finalized refactoring old importer tests working again - (Task #5)
c93cfbb 
- refactored importer to use new classes
- reactivated test cases

---
Task #5: Implement Import Functionality
PhilMFischer added a commit that referenced this issue Aug 14, 2019
@PhilMFischer
Implemented json part cone - (Task #5)
cf45c66 
- added object for translating a json cone into a freecad cone
- provided implementation
- defined json to be in freecad standard units

---
Task #5: Implement Import Functionality
PhilMFischer added a commit that referenced this issue Aug 14, 2019
@PhilMFischer
Implemented json part cylinder - (Task #5)
b49d124 
- Implemented Cylinder properties
- Added test case

---
Task #5: Implement Import Functionality
PhilMFischer added a commit that referenced this issue Aug 14, 2019
@PhilMFischer
Implemented json part sphere - (Task #5)
51a3a61 
- added properties implementation for sphere objects
- added test case
- fixed issue with reocmputation

---
Task #5: Implement Import Functionality
PhilMFischer added a commit that referenced this issue Aug 14, 2019
@PhilMFischer
Trying to swap to bionic - (Task #5)
cc386ec 
- latest freecad versions seem to be available for bionic or beyond.

---
Task #5: Implement Import Functionality
PhilMFischer added a commit that referenced this issue Aug 15, 2019
@PhilMFischer
Corrected Flake warnings - (Task #5)
3247269 
- Corrected indentation in if statement

---
Task #5: Implement Import Functionality
PhilMFischer added a commit that referenced this issue Aug 15, 2019
@PhilMFischer
Renamed part properties to fit to FreeCad convention - (Task #5)
9e8494f 
- Realized, that coordinate systems across FreeCAD and Virtual Satellite
are matching. No further conversions needed.

---
Task #5: Implement Import Functionality
PhilMFischer added a commit that referenced this issue Aug 15, 2019
@PhilMFischer
Added code to deal with geometries - (Task #5)
df6ef26 
- Implemented json part geometry
- added test cases
- added test resource providing an STL example file

---
Task #5: Implement Import Functionality
PhilMFischer added a commit that referenced this issue Aug 16, 2019
@PhilMFischer
Refactored the spread sheet - (Task #5)
df2dc14 
- Removed inheritance to json part
- Added spread sheet as instance to json part
- json part is now writing the sheet
- adjusted importer to not write sheet anymore
- added extra attribute for geometries havin an stl file path attribute
- adjusted test cases

---
Task #5: Implement Import Functionality
PhilMFischer added a commit that referenced this issue Aug 16, 2019
@PhilMFischer
Implemented switch of objects - (Task #5)
7e0d236 
- Added code to clean up FreeCAD objects in case the shape gets switched
in the json
- Adjusted test cases

---
Task #5: Implement Import Functionality
PhilMFischer added a commit that referenced this issue Aug 16, 2019
@PhilMFischer
rearanged package layout to prepare for products - (Task #5)
37554e0 
- Rearanged packages in tests package

---
Task #5: Implement Import Functionality
PhilMFischer added a commit that referenced this issue Aug 16, 2019
@PhilMFischer
Adjusted to cleaned up parameter names in json - (Task #5)
9db7a04 
- Changed export of Virtual Satellite. Adjusted accordingly.

---
Task #5: Implement Import Functionality
PhilMFischer added a commit that referenced this issue Aug 16, 2019
@PhilMFischer
Added test for parsing product - (Task #5)
f9c2731 
- Added example data for a json representing a product
- checked that it is parsed correctly

---
Task #5: Implement Import Functionality
PhilMFischer added a commit that referenced this issue Aug 16, 2019
@PhilMFischer
Change package for json spread sheet - (Task #5)
afb1259 
- the json spread sheet is generic to json io

---
Task #5: Implement Import Functionality
PhilMFischer added a commit that referenced this issue Sep 30, 2019
@PhilMFischer
Trying to force better debug output - (Task #5)
6c055f9 
- Unit test stopped creating resonable debug output

---
Task #5: Implement Import Functionality
PhilMFischer added a commit that referenced this issue Oct 1, 2019
@PhilMFischer
managed to reactivate all tests - (Task #5)
ea13bc9 
- Missing testoutput is due to some minor bug in freecad itself. see:
https://forum.freecadweb.org/viewtopic.php?f=10&t=39732

---
Task #5: Implement Import Functionality
PhilMFischer added a commit that referenced this issue Oct 2, 2019
@PhilMFischer
Unifying test data - (Task #5)
c081429 
- Added test data to test data module for product related test cases

---
Task #5: Implement Import Functionality
PhilMFischer added a commit that referenced this issue Oct 24, 2019
@PhilMFischer
Trying to force better debug output - (Task #5)
dcd23c2 
- Unit test stopped creating resonable debug output

---
Task #5: Implement Import Functionality
PhilMFischer added a commit that referenced this issue Oct 24, 2019
@PhilMFischer
managed to reactivate all tests - (Task #5)
6df536e 
- Missing testoutput is due to some minor bug in freecad itself. see:
https://forum.freecadweb.org/viewtopic.php?f=10&t=39732

---
Task #5: Implement Import Functionality
PhilMFischer added a commit that referenced this issue Oct 24, 2019
@PhilMFischer
Unifying test data - (Task #5)
59b2973 
- Added test data to test data module for product related test cases

---
Task #5: Implement Import Functionality
ghost pushed a commit that referenced this issue Nov 14, 2019
Update commands and add file open dialog to import command - (Task #5)
466e60c 
- Fixed naming in the dialogs
- Switched command positions in InitGui
- Added file open dialog with JSON filter to import command

---
Task #5: Implement Import Functionality
ghost pushed a commit that referenced this issue Nov 14, 2019
Add import functionality to CommandImport - (Task #5)
4e00299 
Use the JsonImporter in the CommandImport

---
Task #5: Implement Import Functionality
ghost pushed a commit that referenced this issue Nov 14, 2019
Refactor importer and add fixture - (Task #5)
b2ef16c 
- Add full import function in JsonImporter
- Use that function in CommandImport
- Add test function for full import
- Add test fixture json file

---
Task #5: Implement Import Functionality
ghost pushed a commit that referenced this issue Nov 21, 2019
Call JsonProductAssembly in full_import function- (Task #5)
f721858 
- Add JsonProductAssembly call
- Add json product tests

---
Task #5: Implement Import Functionality
ghost pushed a commit that referenced this issue Nov 25, 2019
Add inheritance to JsonProductChild - (Task #5)
7ea25ff 
Also:
- Add test data in test_json_data
- Add test case with that data in test_json_product_assembly
- Update test_full_import

---
Task #5: Implement Import Functionality
ghost pushed a commit that referenced this issue Nov 25, 2019
Add functionality for importing a JSON twice - (Task #5)
51af564 
Importing twice should result in the same output as importing once.
json_importer: Create FreeCAD filename from JSON filename
test_json_importer: Add testcase for importing twice
json_product:
- Add function to compare AJsonProducts
- Only create a part if it doesn't exist already
- Clear the placement when reimporting

---
Task #5: Implement Import Functionality
ghost pushed a commit that referenced this issue Nov 25, 2019
Add position and rotation propagation - (Task #5)
205ea9c 
Add a simple solution in json_product_child to propagate values from
parent to children and also test this behavior.

The current method results in children only having an absolute position
(and rotation) instead of a relative one to their parent. This should be
reconsidered with usability and the export functionality in mind.

---
Task #5: Implement Import Functionality
ghost pushed a commit that referenced this issue Nov 27, 2019
Add functionality for full import twice with changes - (Task #5)
05bc713 
Because of CRUD assume that a change from Virtual Satellite side has
always newer information, so we can simply clear the first imported file
and use the newer file. For that:

- Add a function to clear a file in active_document
- Call that function in full_import
- Get FreeCAD document from ProductRoot instead of filename (so
different versions can easily be saved in different files)
- Add new test fixture

---
Task #5: Implement Import Functionality
ghost pushed a commit that referenced this issue Nov 27, 2019
Resolve TODOs - (Task #5)
f7a0f27 
- Add a module directory in FreeCAD Appdata:
	- Create directory in Init
	- Provide it with Environment
	- Use it in CommandImport
- Update documentation and Log Messages
- Update part update in json_product: Now deletes and recreates existing
parts

---
Task #5: Implement Import Functionality
ghost pushed a commit that referenced this issue Nov 27, 2019
Fix missing Mod directory in AppData - (Task #5)
76ebada 
Also add the Mod directory

---
Task #5: Implement Import Functionality
ghost pushed a commit that referenced this issue Nov 28, 2019
Disable full import test cases and add TODOs - (Task #5)
abbaab2 
---
Task #5: Implement Import Functionality
ghost pushed a commit that referenced this issue Nov 28, 2019
Add test_json_product_assembly test cases - (Task #5)
5e03847 
Add:
- test_create_part_product_subassembly_with_root_part
- test_create_part_product_assembly_and_subassembly_with_root_part
- test_create_part_product_assembly_with_root_part_with_traverser (empty
test)

---
Task #5: Implement Import Functionality
ghost pushed a commit that referenced this issue Dec 2, 2019
Add JsonProductAssemblyTreeTraverser - (Task #5)
c3c7cb9 
---
Task #5: Implement Import Functionality
ghost pushed a commit that referenced this issue Dec 2, 2019
Add test_json_product_assemby_tree_traverser - (Task #5)
90b28ba 
- Add first test cases
- Add the test class to TestVirtualSatelliteApp
- Update traverser
- Update product assembly test
---
Task #5: Implement Import Functionality
ghost pushed a commit that referenced this issue Dec 2, 2019
Cleanup traverser - (Task #5)
e7af193 
---
Task #5: Implement Import Functionality
ghost pushed a commit that referenced this issue Dec 3, 2019
Use traverser in importer and add test cases- (Task #5)
694b1dd 
Try to use the traverser in the importer and reactivating the
full_import test case showed problems with assemblies having the same
name and uuid as their part.
To further investigate that, test cases were added in the traverser.

---
Task #5: Implement Import Functionality
ghost pushed a commit that referenced this issue Dec 3, 2019
Add identifiers for product assembly and part files - (Task #5)
a7ce015 
These solve the problem of having a part and an assembly with the same
name and uuid.

- Add the identifiers to json_definitions
- Update the names in part and product files and corresponding test
files

---
Task #5: Implement Import Functionality
ghost pushed a commit that referenced this issue Dec 3, 2019
Reactivate full_import test case and update importer - (Task #5)
043b84c 
---
Task #5: Implement Import Functionality
ghost pushed a commit that referenced this issue Dec 3, 2019
Refactor command_import and resolve TODOs - (Task #5)
2709748 
---
Task #5: Implement Import Functionality
ghost pushed a commit that referenced this issue Dec 3, 2019
Remove unused import and blank lines at EOF - (Task #5)
d0e7fa6 
---
Task #5: Implement Import Functionality
@ghost ghost mentioned this issue Dec 4, 2019
Merged
@ghost ghost closed this as completed Jan 27, 2020
@ghost ghost added this to the Relese_0.1.0_Beta milestone Feb 5, 2020
@ghost ghost mentioned this issue Apr 1, 2020
Merged
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhilMFischer PhilMFischer

Labels
feature New feature or request
Projects
None yet
Milestone
Relese_0.1.0_Beta
Development

Successfully merging a pull request may close this issue.

Feature/task 5 implement import functi virtualsatellite/VirtualSatellite4-FreeCAD-mod
1 participant
@PhilMFischer