Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepare for nativelib deployment through libvcell repo #1455

Merged
merged 4 commits into from
Mar 17, 2025
Merged

prepare for nativelib deployment through libvcell repo #1455

merged 4 commits into from
Mar 17, 2025

Conversation

jcschaff
Copy link
Member

remove vcell-nativelib (moved to libvcell)
update any dependencies to make native code work well on multiple platforms.

@jcschaff jcschaff self-assigned this Mar 11, 2025
@jcschaff jcschaff requested a review from AvocadoMoon March 13, 2025 14:16
AvocadoMoon
AvocadoMoon approved these changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@AvocadoMoon AvocadoMoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems good. Replaced problematic library JDOM to a newer version capable of native compilation, and made copying geometry easier.

@jcschaff jcschaff merged commit 2a23a57 into master Mar 17, 2025
13 checks passed
@jcschaff jcschaff deleted the remove-nativelib branch March 17, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AvocadoMoon AvocadoMoon AvocadoMoon approved these changes

Assignees

@jcschaff jcschaff

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcschaff @AvocadoMoon