Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(kreivo-runtime): add community accounts as xcm senders #388

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions runtime/kreivo/src/xcm_config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ use xcm_builder::{
use xcm_executor::traits::JustTry;
use xcm_executor::XcmExecutor;

mod plurality_community;
use plurality_community::*;
mod communities;
use communities::*;

parameter_types! {
pub const RelayLocation: MultiLocation = MultiLocation::parent();
Expand Down Expand Up @@ -237,7 +237,10 @@ impl xcm_executor::Config for XcmConfig {
}

/// Only communities are allowed to dispatch xcm messages
pub type CanSendXcmMessages = pallet_communities::Origin<Runtime>;
pub type CanSendXcmMessages = (
pallet_communities::Origin<Runtime>,
SignedByCommunityToPlurality<Runtime>,
);

/// Only signed origins are allowed to execute xcm transactions
pub type CanExecuteXcmTransactions = (
Expand All @@ -257,8 +260,8 @@ pub type XcmRouter = (
impl pallet_xcm::Config for Runtime {
type RuntimeEvent = RuntimeEvent;
type SendXcmOrigin = EnsureXcmOrigin<RuntimeOrigin, CanSendXcmMessages>;
type XcmRouter = XcmRouter;
type ExecuteXcmOrigin = EnsureXcmOrigin<RuntimeOrigin, CanExecuteXcmTransactions>;
type XcmRouter = XcmRouter;
type XcmExecuteFilter = Nothing;
// ^ Disable dispatchable execute on the XCM pallet.
type XcmExecutor = XcmExecutor<XcmConfig>;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
use super::*;

use crate::Communities;
use sp_runtime::SaturatedConversion;
use core::marker::PhantomData;
use frame_support::{traits::OriginTrait, PalletId};
use pallet_communities::AccountIdOf;
use sp_runtime::{
traits::{AccountIdConversion, TryConvert},
SaturatedConversion,
};
use xcm::v3::{BodyId, Junction::Plurality};
use xcm_executor::traits::ConvertLocation;

Expand Down Expand Up @@ -40,3 +46,23 @@ impl<Network: Get<Option<NetworkId>>, AccountId: From<[u8; 32]> + Into<[u8; 32]>
Some((*id).into())
}
}

pub struct SignedByCommunityToPlurality<T>(PhantomData<T>);
impl<T, OuterOrigin> TryConvert<OuterOrigin, xcm::v3::MultiLocation> for SignedByCommunityToPlurality<T>
where
OuterOrigin: OriginTrait<AccountId = AccountIdOf<T>> + Clone,
T: pallet_communities::Config,
xcm::v3::Junction: TryFrom<pallet_communities::Origin<T>>,
{
fn try_convert(o: OuterOrigin) -> Result<xcm::v3::MultiLocation, OuterOrigin> {
let Some(account_id) = o.clone().into_signer() else {
return Err(o.clone());
};
let Some((_, community_id)) = PalletId::try_from_sub_account(&account_id) else {
return Err(o.clone());
};
let origin = pallet_communities::Origin::<T>::new(community_id);
let j = xcm::v3::Junction::try_from(origin).map_err(|_| o)?;
Ok(j.into())
}
}