Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AssetId to support DOT #359

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Update AssetId to support DOT #359

merged 1 commit into from
Apr 12, 2024

Conversation

olanod
Copy link
Member

@olanod olanod commented Apr 12, 2024 •
edited
Loading

The new representation allows to represent the Location .2//polkadot (parents:2, X1(GlobalConsensus(Polkadot))). We don't need migrations since we only have a FungibleAssetLocation::Sibling {id, pallet, index} that encodes the same as the new FungibleAssetLocation::Sibling(Para).

@olanod olanod requested a review from pandres95 April 12, 2024 16:11
pandres95
pandres95 approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@pandres95 pandres95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Storage is preserved, so no migrations are needed.

✅ Tested via Chopsticks.
👍 LGTM.

@pandres95 pandres95 merged commit cc244da into master Apr 12, 2024
2 checks passed
@pandres95 pandres95 deleted the update-asset-id-for-external branch April 12, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pandres95 pandres95 pandres95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olanod @pandres95