Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using object representation for cameras #23

Merged
merged 13 commits into from
Feb 9, 2024
Merged

Using object representation for cameras #23

merged 13 commits into from
Feb 9, 2024

Conversation

janmn
Copy link
Collaborator

@janmn janmn commented Jan 26, 2024

Added a 'camera' class and included it in main.py.

This fixes #22

@janmn janmn requested a review from lkiesow January 26, 2024 17:32
Copy link
Member

@lkiesow lkiesow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick initial review. I didn't yet look at updating the calendar.

camera.py Outdated Show resolved Hide resolved
camera.py Outdated Show resolved Hide resolved
camera.py Outdated Show resolved Hide resolved
camera.py Outdated Show resolved Hide resolved
camera.py Outdated Show resolved Hide resolved
camera.py Outdated Show resolved Hide resolved
main.py Outdated Show resolved Hide resolved
main.py Outdated Show resolved Hide resolved
Jan-Matthis and others added 5 commits February 8, 2024 18:55
This fixes the flake8 issues except the line length. This should now
pass the CI tests.
This patch moves all files into one Python package.
This patch updates the way configuration is mapped to camera object
attributes. This includes renaming some internal attributes of the
`Camera` class.

This patch also finally uses the credentials from the configuration
files to talk to the cameras.
This patch switches to using a logger for logging instead of just using
print statements.
This patch catches HTTP errors, logs them and handles them gracefully
instead of crashing the tool.
This patch adds a class `Agent` to handle all of the communication to
Opencast about capture agents. This also separates calendar updates and
camera control.

This fixes #20
Instead of hard-coding the preset, this patch allows users to specify
the active and inactive profiles in the configuration.

This fixes #18
@lkiesow lkiesow merged commit c8f7d5f into main Feb 9, 2024
6 checks passed
@lkiesow lkiesow deleted the camera_objects branch February 9, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass on camera object/dict
2 participants