-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using object representation for cameras #23
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkiesow
requested changes
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick initial review. I didn't yet look at updating the calendar.
lkiesow
force-pushed
the
camera_objects
branch
from
February 8, 2024 15:02
0779c90
to
942267c
Compare
…sing arguments easier
This fixes the flake8 issues except the line length. This should now pass the CI tests.
This patch moves all files into one Python package.
lkiesow
force-pushed
the
camera_objects
branch
from
February 8, 2024 17:55
5894775
to
42039fa
Compare
This patch updates the way configuration is mapped to camera object attributes. This includes renaming some internal attributes of the `Camera` class. This patch also finally uses the credentials from the configuration files to talk to the cameras.
This patch switches to using a logger for logging instead of just using print statements.
This patch catches HTTP errors, logs them and handles them gracefully instead of crashing the tool.
This patch adds a class `Agent` to handle all of the communication to Opencast about capture agents. This also separates calendar updates and camera control. This fixes #20
lkiesow
approved these changes
Feb 9, 2024
Instead of hard-coding the preset, this patch allows users to specify the active and inactive profiles in the configuration. This fixes #18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a 'camera' class and included it in
main.py
.This fixes #22