Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More features in blocking mode, ulid() is created per feed #19

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

dss-vipps
Copy link
Contributor

@dss-vipps dss-vipps commented Dec 7, 2023

  • Remove changefeed.ulid(). However, support for such functions already created is kept, they will still work, but new ones will not be created in new installations.
  • Instead, changefeed.[ulid:yourschema.YourTable]() is made available
  • Also, changefeed.[lock:*] gets some new arguments, and if you only need a single ulid you can just grab it from there

These changes are done because the previous interface didn't allow writing to more than one feed in one database transaction; this quickly broke down in real world usage.

Copy link
Member

@dtitov dtitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My SQL knowledge is not enough to check the validity of the script itself, but I get the rationale behind this change (after the discussion in Slack) and the described usage seems OK 👍

@dss-vipps
Copy link
Contributor Author

Rebased

@dss-vipps dss-vipps force-pushed the ulid-function-per-feed branch from c855f54 to cca9874 Compare December 8, 2023 07:58
@dss-vipps dss-vipps merged commit f1acb83 into main Dec 8, 2023
@dss-vipps dss-vipps deleted the ulid-function-per-feed branch December 8, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants