update BatchRecordChangeUpdateResponse #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdb
requested changes
Nov 15, 2019
vinyldns/batch_changes_resources.go
Outdated
| Comments string `json:"comments,omitempty"` | ||
| OwnerGroupID string `json:"ownerGroupId,omitempty"` | ||
| Changes []RecordChange `json:"changes,omitempty"` | ||
| ID string `json:"id,omitempty"` |
There was a problem hiding this comment.
Would you mind addressing this formatting issue, please? :)
britneywright
commented
Nov 15, 2019
vinyldns/batch_changes_resources.go
Outdated
| Comments string `json:"comments,omitempty"` | ||
| OwnerGroupID string `json:"ownerGroupId,omitempty"` | ||
| Changes []RecordChange `json:"changes,omitempty"` | ||
| ID string `json:"id,omitempty"` |
There was a problem hiding this comment.
so this looks like it has extra indentation here, but when i view the file it shows the ID attribute aligned with everything else.
diff view:
file view:
b31ffe8 to
ae3261f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Return full API response after creating a batch change.