Bug 1851168 [wpt PR 41761] - Locate parent fragment of nested OOF mul…

…ticol correctlier., a=testonly Automatic update from web-platform-tests Locate parent fragment of nested OOF multicol correctlier. Fix a mistake from crrev.com/c/4798090 . We shouldn't require the multicol container that we stop at to be in-flow. The only actual code change here is precisely that: We will still stop searching when an entry in the containing block chain is in-flow and the containing block of that one is a fragmentation context root (e.g. multicol container), but don't require this fragmentation context root to be in-flow. It's the right container of the inner OOF multicol regardless of that. The rest of the code changes are just an attempt to make it a bit more readable. We were skipping one element in the chain (the containing block of the OOF input multicol container box), and went directly to the containing block of that one. It really shouldn't matter in practice, because if the containing block (CB) of the OOF input multicol container box also is a multicol container, we're not going to stop there anyway, because the fragments of the OOF input box still must belong higher up in the tree, participating in an outer fragmentation context, because we can be sure that CB isn't the outermost fragmentation context, because in that case we would still be inside its layout algorithm, and therefore wouldn't have to mutate its fragment (since it wouldn't exist yet), so we won't be here in such cases. But, unlike this paragraph of explanation, the code is a bit easier to follow, if we start at the input box itself. Bug: 1475385 Change-Id: Ifeb61ac1633b9a10a2a72b2871f817bfd24855d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4836053 Reviewed-by: Alison Maher <almaher@microsoft.com> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1191979} -- wpt-commits: e83b508b03cbdbcdc51a22b3fa935251503673de wpt-pr: 41761
vinnydiehl · Sep 13, 2023 · f47d11f · f47d11f
1 parent 3baa43f
commit f47d11f
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 0 deletions.
diff --git a/...rashtests/oof-in-relpos-in-oof-multicol-in-oof-in-relpos-in-oof-multicol-in-multicol.html b/...rashtests/oof-in-relpos-in-oof-multicol-in-oof-in-relpos-in-oof-multicol-in-multicol.html
@@ -0,0 +1,16 @@
+<!DOCTYPE html>
+<link rel="author" title="Morten Stenshorne" href="mailto:mstensho@chromium.org">
+<link rel="help" href="https://bugs.chromium.org/p/chromium/issues/detail?id=1475385">
+<div style="columns:2;">
+  <div style="columns:2; position:absolute;">
+    <div style="position:relative;">
+      <div style="position:absolute;">
+        <div style="columns:2; position:absolute;">
+          <div style="position:relative;">
+            <div style="position:absolute; height:100px;"></div>
+          </div>
+        </div>
+      </div>
+    </div>
+  </div>
+</div>
diff --git a/...rashtests/oof-in-relpos-in-oof-multicol-in-relpos-in-oof-multicol-in-relpos-multicol.html b/...rashtests/oof-in-relpos-in-oof-multicol-in-relpos-in-oof-multicol-in-relpos-multicol.html
@@ -0,0 +1,14 @@
+<!DOCTYPE html>
+<link rel="author" title="Morten Stenshorne" href="mailto:mstensho@chromium.org">
+<link rel="help" href="https://bugs.chromium.org/p/chromium/issues/detail?id=1475385">
+<div style="position:relative; columns:2;">
+  <div style="position:absolute; columns:2;">
+    <div style="position:relative;">
+      <div style="position:absolute; columns:2;">
+        <div style="position:relative;">
+          <div style="position:absolute; height:200px;"></div>
+        </div>
+      </div>
+    </div>
+  </div>
+</div>