Skip to content

Commit

Permalink
fix: unit tests for tfmigrate
Browse files Browse the repository at this point in the history
  • Loading branch information
GoodmanBen committed Mar 13, 2022
1 parent 0aecbcf commit 83fa280
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion tfmigrate/mock_migrator_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ func TestMockMigratorConfigNewMigrator(t *testing.T) {

for _, tc := range cases {
t.Run(tc.desc, func(t *testing.T) {
got, err := tc.config.NewMigrator(tc.o, false)
got, err := tc.config.NewMigrator(tc.o)
if tc.ok && err != nil {
t.Fatalf("unexpected err: %s", err)
}
Expand Down
4 changes: 2 additions & 2 deletions tfmigrate/multi_state_migrator_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ func TestMultiStateMigratorConfigNewMigrator(t *testing.T) {

for _, tc := range cases {
t.Run(tc.desc, func(t *testing.T) {
got, err := tc.config.NewMigrator(tc.o, false)
got, err := tc.config.NewMigrator(tc.o)
if tc.ok && err != nil {
t.Fatalf("unexpected err: %s", err)
}
Expand Down Expand Up @@ -280,7 +280,7 @@ func TestAccMultiStateMigratorApply(t *testing.T) {
o.PlanOut = "foo.tfplan"
}

m := NewMultiStateMigrator(fromTf.Dir(), toTf.Dir(), tc.fromWorkspace, tc.toWorkspace, actions, o, tc.force, false)
m := NewMultiStateMigrator(fromTf.Dir(), toTf.Dir(), tc.fromWorkspace, tc.toWorkspace, actions, o, tc.force)
err = m.Plan(ctx)
if err != nil {
t.Fatalf("failed to run migrator plan: %s", err)
Expand Down
2 changes: 1 addition & 1 deletion tfmigrate/state_import_action_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ resource "aws_iam_user" "baz" {
NewStateImportAction("aws_iam_user.baz", "baz"),
}

m := NewStateMigrator(tf.Dir(), "default", actions, &MigratorOption{}, false, false)
m := NewStateMigrator(tf.Dir(), "default", actions, &MigratorOption{}, false)
err = m.Plan(ctx)
if err != nil {
t.Fatalf("failed to run migrator plan: %s", err)
Expand Down
6 changes: 3 additions & 3 deletions tfmigrate/state_migrator_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ func TestStateMigratorConfigNewMigrator(t *testing.T) {

for _, tc := range cases {
t.Run(tc.desc, func(t *testing.T) {
got, err := tc.config.NewMigrator(tc.o, false)
got, err := tc.config.NewMigrator(tc.o)
if tc.ok && err != nil {
t.Fatalf("unexpected err: %s", err)
}
Expand Down Expand Up @@ -181,7 +181,7 @@ resource "aws_iam_user" "qux" {
NewStateImportAction("aws_iam_user.qux", "qux"),
}

m := NewStateMigrator(tf.Dir(), tc.workspace, actions, &MigratorOption{}, false, false)
m := NewStateMigrator(tf.Dir(), tc.workspace, actions, &MigratorOption{}, false)
err = m.Plan(ctx)
if err != nil {
t.Fatalf("failed to run migrator plan: %s", err)
Expand Down Expand Up @@ -254,7 +254,7 @@ resource "aws_security_group" "baz" {}
o := &MigratorOption{}
o.PlanOut = "foo.tfplan"

m := NewStateMigrator(tf.Dir(), "default", actions, o, true, false)
m := NewStateMigrator(tf.Dir(), "default", actions, o, true)
err = m.Plan(ctx)
if err != nil {
t.Fatalf("failed to run migrator plan: %s", err)
Expand Down
2 changes: 1 addition & 1 deletion tfmigrate/state_mv_action_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ resource "aws_security_group" "baz" {}
NewStateMvAction("aws_security_group.bar", "aws_security_group.bar2"),
}

m := NewStateMigrator(tf.Dir(), "default", actions, &MigratorOption{}, false, false)
m := NewStateMigrator(tf.Dir(), "default", actions, &MigratorOption{}, false)
err = m.Plan(ctx)
if err != nil {
t.Fatalf("failed to run migrator plan: %s", err)
Expand Down
2 changes: 1 addition & 1 deletion tfmigrate/state_rm_action_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ resource "aws_security_group" "baz" {}
NewStateRmAction([]string{"aws_security_group.qux"}),
}

m := NewStateMigrator(tf.Dir(), "default", actions, &MigratorOption{}, false, false)
m := NewStateMigrator(tf.Dir(), "default", actions, &MigratorOption{}, false)
err = m.Plan(ctx)
if err != nil {
t.Fatalf("failed to run migrator plan: %s", err)
Expand Down

0 comments on commit 83fa280

Please sign in to comment.