Add parallel PHP syntax check on template files #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this, absolutely no automated checks were done on template files now we at least ensure that they are valid PHP files. The parallel run should work correctly on macOS and other Unix-like systems. On Windows, we fallback to sequential execution. This takes around 1 second on my not so fast 2/4 cores Intel laptop.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #481 +/- ##
============================================
- Coverage 18.23% 17.97% -0.26%
- Complexity 2003 2024 +21
============================================
Files 71 72 +1
Lines 5407 5495 +88
============================================
+ Hits 986 988 +2
- Misses 4421 4507 +86 |
vincent-peugnet
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, absolutely no automated checks were done on template files now we at least ensure that they are valid PHP files.
The parallel run should work correctly on macOS and other Unix-like systems. On Windows, we fallback to sequential execution.
This takes around 1 second on my not so fast 2/4 cores Intel laptop.