-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add support for Plasma 6 #24
base: main
Are you sure you want to change the base?
Conversation
- Convert deprecated metadata.desktop files to metadata.json files via desktoptojson - Add a KPackageStructure key/value pair when necessary Out of caution, the old metadata.desktop files were not removed.
Try this PR out for yourself! git clone https://github.com/vinceliuice/Graphite-kde-theme
cd Graphite-kde-theme
# Fetch pull request as branch
git fetch origin pull/24/head
git checkout -b pull-request-24 FETCH_HEAD |
A separate plasma6 sddm is installed, rather than overwriting the old sddm theme, so that the change isn't breaking. This can be tested with sddm-greeter-qt6 --test-mode --theme sddm/Graphite-plasma6. ISSUES: Text field is wrong size
Update: I made a preliminary fix for the SDDM theme by comparing import statements and objects to FlawsWrong size Original: reference You can test and debug via |
Using plasma 6.1, installing your branch kept falling back to the default, even though --test-mode worked fine. Took me a while to track down why it kept trying to load it through the (now non-existent)
--- a/sddm/Graphite-nord-plasma6/metadata.desktop
+++ b/sddm/Graphite-nord-plasma6/metadata.desktop
@@ -5,7 +5,7 @@ Author=Vince Liuice
Copyright=(c) 2019, Vince Liuice
License=CC-BY-SA
Type=sddm-theme
-Version=0.1.0
+Version=0.2.0
Website=https://github.com/vinceliuice/Graphite-kde-theme
Screenshot=preview.png
MainScript=Main.qml
@@ -14,3 +14,4 @@ TranslationsDirectory=translations
Email=vinceliuice@hotmail.com
Theme-Id=Graphite-nord
Theme-API=2.0
+QtVersion=6 I have to say, the docs aren't great! https://develop.kde.org/docs/plasma/theme/theme-porting-to-plasma6/ seems very incomplete, and when it gets to SDDM it just says consult their docs (which don't seem to exist!) |
Is their any update on getting this merged soon @swomf? Love the project, one of the best themes. |
These should be non-breaking changes designed to port this theme for plasma6.
In general, my changes were simply using
desktoptojson
, some manual.json
tweaks, and changing thedecoration.svg
aurorae boxes in Inkscape to correctly render window border outlines.Addresses #23.
Flaws
install.sh
.EDIT: I have started work on porting the SDDM theme, see below