Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pcntl_alarm to the list of impure functions #6802

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Add pcntl_alarm to the list of impure functions #6802

merged 1 commit into from
Nov 3, 2021

Conversation

l-x
Copy link
Contributor

@l-x l-x commented Nov 3, 2021

pcntl_alarm is currently considered as a pure function, which is not correct.

See https://psalm.dev/r/c51166d9bb

@psalm-github-bot
Copy link

I found these snippets:

https://psalm.dev/r/c51166d9bb
<?php

pcntl_alarm(123);
Psalm output (using commit 5dadb02):

ERROR: UnusedFunctionCall - 3:1 - The call to pcntl_alarm is not used

@l-x l-x closed this Nov 3, 2021
@l-x l-x reopened this Nov 3, 2021
@weirdan weirdan added the release:fix The PR will be included in 'Fixes' section of the release notes label Nov 3, 2021
@weirdan weirdan merged commit 0bb1648 into vimeo:master Nov 3, 2021
@weirdan
Copy link
Collaborator

weirdan commented Nov 3, 2021

Thanks!

@l-x l-x deleted the impure_pcntl_alarm branch November 3, 2021 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants