[n/a] add Tabs documentation #3
Conversation
| data-action="keyup->tabs#cycleTabs" | ||
| role="tablist" | ||
| > | ||
| {['Tab 1', 'Tab 2', 'Tab 3'].map((text, i) => ( |
There was a problem hiding this comment.
Super minor, but the JSX here might potentially trip up newer folks who aren't familiar what parts are Stimulus syntax and what's JSX.
There was a problem hiding this comment.
fair, i struggled with that. should we commit to twig demo code? the hold up for me was i couldnt actually (or easily) verify the twig code the way i could the jsx code
There was a problem hiding this comment.
oh and then i thought i could just manually do multiple elements but i figured the loop logic was helpful for the attributes even if it was in jsx 🤷
There was a problem hiding this comment.
somewhat related, entirely nit/subjective: did you consider having everything in a single array? like
tabsAndTabpanels = [
{
tabContent: …,
tabpanelContent: …,
},
…
]
👍 you just mean home & end are missing?
👍
this is already there unless i'm missing something?
👍 |
huh. correct. don't know what I was looking at ha
oh interesting I missed that
"huh. correct. don't know what I was looking at ha" take 2 🤷♂️ |
667bc3f to
bd4ddf2
Compare
🚀 https://code.viget.com/stimulus-controllers/tabs/