Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update development tooling #462

Merged
merged 6 commits into from
Jan 24, 2019
Merged

chore: Update development tooling #462

merged 6 commits into from
Jan 24, 2019

Conversation

brandonocasey
Copy link
Contributor

Based on #461

@brandonocasey brandonocasey force-pushed the chore/generator-v7 branch 2 times, most recently from 80e4ff8 to 7d1948a Compare January 15, 2019 16:11
misteroneill
misteroneill reviewed Jan 17, 2019
View reviewed changes
Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but since it's a large change, I'd like to independently verify that the build outputs are good.

@misteroneill misteroneill changed the title Chore/generator v7 chore: Update development tooling Jan 17, 2019
@misteroneill
Copy link
Member

@brandonocasey The tests are failing in Chrome 71 for me locally due to play() being called without user interaction - they pass on master. Maybe some kind of Karma difference?

@misteroneill
Copy link
Member

Actually, it seems that it was user error. I am no longer seeing the test failures.

@misteroneill misteroneill changed the base branch from ignore/fix-rollup-circular to master January 24, 2019 19:50
misteroneill
misteroneill approved these changes Jan 24, 2019
View reviewed changes
Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing locally and the dist files seem to work fine. LGTM.

@misteroneill misteroneill merged commit d1171ec into master Jan 24, 2019
@misteroneill misteroneill deleted the chore/generator-v7 branch January 24, 2019 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misteroneill misteroneill misteroneill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandonocasey @misteroneill