Fix firefox+flash mousemove bubbling #899
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ideo-js-swf#37 Also fixed a bug introduced by videojs#898. First arg of setTimeout was `this`.
|
Are you sure this doesn't cause the event to trigger multiple times on other browsers? |
|
Yeah, I assumed it would, and I'm relying on the fact that the mousemove listener is extremely lightweight. We could do a Firefox UA check, but I was hoping to avoid that. I guess I should make sure it doesn't bubble in this case. On Dec 16, 2013, at 9:29 PM, Gary Katsevman notifications@github.com wrote:
|
|
As long as it isn't causing adverse affects. |
Also added link to bugzilla bug for tracking the status of this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes videojs/video-js-swf#37