Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Assume DASH MIME type when an MPD source URL is given #7602

Merged
merged 2 commits into from
Mar 2, 2022

Conversation

amtins
Copy link
Contributor

@amtins amtins commented Jan 10, 2022

Description

Since http-streaming plays DASH, adding this feature will allow a DASH source to be provided without necessarily indicating the media type.

player.src('https://domain.com/video.mpd') //👌

Specific Changes proposed

  • Add application/dash+xml to the MimetypesKind object
  • Update old unavailable link listing different mime types

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #7602 (5b6d32a) into main (eeda26f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7602   +/-   ##
=======================================
  Coverage   80.24%   80.24%           
=======================================
  Files         116      116           
  Lines        7325     7325           
  Branches     1771     1771           
=======================================
  Hits         5878     5878           
  Misses       1447     1447           
Impacted Files Coverage Δ
src/js/utils/mimetypes.js 72.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeda26f...5b6d32a. Read the comment docs.

Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible to me!

@misteroneill misteroneill added the needs: LGTM Needs one or more additional approvals label Jan 10, 2022
@misteroneill misteroneill changed the title Feat/add dash mime type to the MimetypesKind object feat: Assume DASH MIME type when an MPD source URL is given Jan 10, 2022
@misteroneill misteroneill added confirmed minor This PR can be added to a minor release. It should not be added to a patch release. and removed needs: LGTM Needs one or more additional approvals labels Jan 11, 2022
@misteroneill misteroneill merged commit a0bb526 into videojs:main Mar 2, 2022
@amtins amtins deleted the feat/add-dash-mimetype branch July 11, 2022 13:02
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed minor This PR can be added to a minor release. It should not be added to a patch release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants