fix: clear readyQueue with dispose #6967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
approved these changes
Dec 1, 2020
|
I updated this pull request slightly when adding a unit test I realized that this case will also throw an error when it happens about |
brandonocasey
commented
Dec 3, 2020
src/js/mixins/evented.js
Outdated
| const validateTarget = (target) => { | ||
| if (!target.nodeName && !isEvented(target)) { | ||
| throw new Error('Invalid target; must be a DOM node or evented object.'); | ||
| const validateTarget = (target, obj, fnName) => { |
There was a problem hiding this comment.
Made these errors more specific.
brandonocasey
commented
Dec 3, 2020
src/js/mixins/evented.js
Outdated
| if (!target.nodeName && !isEvented(target)) { | ||
| throw new Error('Invalid target; must be a DOM node or evented object.'); | ||
| const validateTarget = (target, obj, fnName) => { | ||
| if (!target || (!target.nodeName && !isEvented(target))) { |
There was a problem hiding this comment.
Check if target is null before trying to check a property on it.
brandonocasey
commented
Dec 3, 2020
src/js/mixins/evented.js
Outdated
| @@ -398,6 +418,8 @@ const EventedMixin = { | |||
| * Whether or not the default behavior was prevented. | |||
| */ | |||
| trigger(event, hash) { | |||
| validateTarget(this.eventBusEl_, this, 'trigger'); | |||
There was a problem hiding this comment.
validate on trigger, this is likely the cause of the issue we see in dom
|
If it can be split out into two PRs, that would be nice. The changes look good. |
|
Moved the evented changes to #6982 |
gkatsev
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Seems like we never clear the internal
readyQueue_when callingdisposewhich may cause the issues seen in #6701 (comment) and #5706