Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined variable: "$ie8screen" #3587

Closed
knvpk opened this issue Aug 29, 2016 · 6 comments
Closed

Undefined variable: "$ie8screen" #3587

knvpk opened this issue Aug 29, 2016 · 6 comments
Assignees

Comments

@knvpk
Copy link

knvpk commented Aug 29, 2016

Description

when using the videojs with webpack automation tool (minifying), it is saying error

Undefined variable: "$ie8screen".
      in project_location/bower_components/video.js/dist/video-js.css (line 1297, column 1)

@misteroneill
Copy link
Member

What version of video.js are you using?

@misteroneill misteroneill added needs: more info Please make enough detailed information is added to be actionable. needs: confirmation labels Aug 29, 2016
@gkatsev
Copy link
Member

gkatsev commented Aug 29, 2016

I'm guessing webpack is complaining about the commented out css variable here? https://github.com/videojs/video.js/blob/v5.12.1/dist/video-js.css#L1297-L1318

@knvpk
Copy link
Author

knvpk commented Aug 30, 2016

Hi im using 15.12.1 version, the variable is not commented out so webpack is showing the error and stopping the build.

@brandonocasey
Copy link
Contributor

you can try using the video.min.css, as that will not have the $ie8screen variable in it

@gkatsev
Copy link
Member

gkatsev commented Aug 30, 2016

As far as I can tell, it's commented out. Though, we should just remove that comment altogether, it's not necessary.

gkatsev added a commit to gkatsev/video.js that referenced this issue Sep 19, 2016
@gkatsev gkatsev self-assigned this Sep 19, 2016
@gkatsev
Copy link
Member

gkatsev commented Sep 19, 2016

Should be fixed by #3625

@gkatsev gkatsev removed needs: confirmation needs: more info Please make enough detailed information is added to be actionable. labels Sep 19, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants