Update rollup and multi-entry plugin #32
Conversation
scripts/modules.rollup.config.js
Outdated
| @@ -9,8 +9,8 @@ import babel from 'rollup-plugin-babel'; | |||
| import json from 'rollup-plugin-json'; | |||
|
|
|||
| export default { | |||
| moduleName: 'm3u8-parser', | |||
| entry: 'src/index.js', | |||
| name: 'm3u8_parser', | |||
There was a problem hiding this comment.
This is something I'm not sure on - rollup will complain about the hyphen, but I can't tell if this would then require a change to the import statements for things that require m3u8-parser?
There was a problem hiding this comment.
It should be fine, but I think we should go with camelcase (not a big deal, just preference).
| "rollup-plugin-babel": "^2.7.1", | ||
| "rollup-plugin-commonjs": "^8.0.2", | ||
| "rollup-plugin-json": "^2.1.1", | ||
| "rollup-plugin-multi-entry": "^2.0.1", | ||
| "rollup-plugin-multi-entry": "^2.0.2", |
There was a problem hiding this comment.
Was there any specific reason for this change?
There was a problem hiding this comment.
I believe that patch version is needed for the update in multi-entry
Though it's possible that 2.0.1 also contains it, I'm not actually sure...
scripts/modules.rollup.config.js
Outdated
| @@ -9,8 +9,8 @@ import babel from 'rollup-plugin-babel'; | |||
| import json from 'rollup-plugin-json'; | |||
|
|
|||
| export default { | |||
| moduleName: 'm3u8-parser', | |||
| entry: 'src/index.js', | |||
| name: 'm3u8_parser', | |||
There was a problem hiding this comment.
It should be fine, but I think we should go with camelcase (not a big deal, just preference).
It looks like the lack of a
package-lock.jsonis the root cause of tests failing - since the versions ofrollup/rollup-plugin-multi-entrydon't play nice with each other as of recently (at least, that's what a cursory search appears to indicate)