fix(parser): ensure dateRange uses startDate for condition #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there an update on this can we get it merged? |
gkatsev
previously approved these changes
Jan 28, 2025
not inherently wrong, but there's more to it
adrums86
requested changes
Jan 28, 2025
| @@ -715,7 +715,7 @@ export default class Parser extends Stream { | |||
| message: 'EXT-X-DATERANGE with an END-ON-NEXT=YES attribute must not contain DURATION or END-DATE attributes' | |||
| }); | |||
| } | |||
| if (dateRange.duration && dateRange.endDate) { | |||
There was a problem hiding this comment.
I'll defer to the discussion in #186 , but I think we may want to do something like
if (dateRange.startDate && dateRange.duration && dateRange.endDate)instead.
Perhaps with a warning and early return if the startDate + duration !== endDate to ensure we don't create any bad dateRanges.
There was a problem hiding this comment.
I updated the constraint to include dateRange.endDate, ensuring that dateRanges[index].endDate is created according to the specification and that a valid startDate is present. This should be sufficient to prevent the creation of invalid dateRanges, as you mentioned.
Additionally, I added a warning.
Triggers a warn event when an EXT-X-DATERANGE tag includes both DURATION and END-DATE but lacks the required START-DATE. Ensures better HLS spec compliance.
gkatsev
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related with issue #186