Skip to content

Commit

Permalink
Merge pull request #1289 from vegasmurphy/textTrackPolling
Browse files Browse the repository at this point in the history
Add textTrack polling for browsers that don't have textTrack onchange events
  • Loading branch information
mangui authored Aug 8, 2017
2 parents 62709ab + b166d1b commit e737dea
Showing 1 changed file with 14 additions and 3 deletions.
17 changes: 14 additions & 3 deletions src/controller/subtitle-track-controller.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,15 +60,26 @@ class SubtitleTrackController extends EventHandler {
}

this.trackChangeListener = this._onTextTracksChanged.bind(this);
this.media.textTracks.addEventListener('change', this.trackChangeListener);

this.useTextTrackPolling = !(this.media.textTracks && 'onchange' in this.media.textTracks);
if (this.useTextTrackPolling) {
this.subtitlePollingInterval = setInterval(() => {
this.trackChangeListener();
}, 500);
} else {
this.media.textTracks.addEventListener('change', this.trackChangeListener);
}
}

onMediaDetaching() {
if (!this.media) {
return;
}

this.media.textTracks.removeEventListener('change', this.trackChangeListener);
if (this.useTextTrackPolling) {
clearInterval(this.subtitlePollingInterval);
} else {
this.media.textTracks.removeEventListener('change', this.trackChangeListener);
}

this.media = undefined;
}
Expand Down

0 comments on commit e737dea

Please sign in to comment.