Add ExcludeCollectionIterator (#505) #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ExcludeCollectionIterator for ICollection types in Exclude operator.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #608 +/- ##
==========================================
+ Coverage 93.29% 93.31% +0.02%
==========================================
Files 242 242
Lines 7755 7767 +12
Branches 1595 1596 +1
==========================================
+ Hits 7235 7248 +13
+ Misses 329 328 -1
Partials 191 191 ☔ View full report in Codecov by Sentry. |
- Replace GetListSequences with GetAllSequences. - Add ExcludeCollectionBehavior.
viceroypenguin
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ExcludeCollectionIteratorforICollectiontypes inExcludeoperator.
Rename
ExcludeIteratortoExcludeListIteratorfor name consistency.Tests for
ExcludeCollectionIterator:GetListSequenceswithGetAllSequences.ExcludeCollectionBehavior.Fixes #505