fix to simplify randomsetsetimpl code#540 #554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My PR appears to solve this issue code#540 |
|
Thanks! You're on the right track. However, a proper solution will not need the |
|
Ahhhh! That makes sense! Let me take another crack at this. |
|
Took away the 'seeder' parameter as I shouldn't have added it in. Please let me know if I can add or refactor any part of this. |
|
I'm sorry, your work does not even build, so I am rejecting this PR. Please review #568 for an example of a proper change. I encourage you to try again with another issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.