Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address net8-preview changes #491

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Address net8-preview changes #491

merged 2 commits into from
Aug 17, 2023

Conversation

viceroypenguin
Copy link
Owner

@viceroypenguin viceroypenguin commented Aug 17, 2023

This PR fixes changes from the latest net8 preview compiler:

  • a newly generated CA1859 warning;
  • the expected exception thrown by CopyTo

@viceroypenguin viceroypenguin enabled auto-merge (squash) August 17, 2023 04:50
@viceroypenguin viceroypenguin changed the title Address CA1859 warning Address net8-preview changes Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage: 95.45% and project coverage change: +0.05% 🎉

Comparison is base (2f8e98a) 92.97% compared to head (c07b095) 93.02%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #491      +/-   ##
==========================================
+ Coverage   92.97%   93.02%   +0.05%     
==========================================
  Files         245      249       +4     
  Lines        8094     8182      +88     
  Branches     1617     1635      +18     
==========================================
+ Hits         7525     7611      +86     
+ Misses        359      357       -2     
- Partials      210      214       +4     
Files Changed Coverage Δ
Source/SuperLinq/Permutations.cs 94.82% <ø> (ø)
Source/SuperLinq.Async/WhereLag.cs 91.66% <91.66%> (ø)
Source/SuperLinq.Async/WhereLead.cs 93.33% <93.33%> (ø)
Source/SuperLinq.Async/AsyncSuperEnumerable.cs 100.00% <100.00%> (ø)
Source/SuperLinq/WhereLag.cs 100.00% <100.00%> (ø)
Source/SuperLinq/WhereLead.cs 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viceroypenguin viceroypenguin merged commit d72dcbc into master Aug 17, 2023
@viceroypenguin viceroypenguin deleted the net8-bugfix branch August 17, 2023 05:07
@viceroypenguin viceroypenguin added this to the 5.3.0 milestone Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant