added test coverage for cases where the task is not via ThrowIfCancel…

[julienasp]

If the task is not cancelled via ThrowIfCancellationRequested(), we still handle it correctly in the implementation but no test were made for those.

[julienasp]

if (successTask == delayTask)
{
    // depending on the implementation ThrowIfCancellationRequested() might not be called    
    cts.Cancel(); 
    _ = await moveNextTask.ConfigureAwait(false);
  
    // this covers it but no test were made for that, so i added 2 to make it explicit
    throw new TimeoutException("The operation has timed out."); 
}
							

[julienasp]

this also made me realise that you didnt go with cts.CancelAfter is it for performance reasons @viceroypenguin ?

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (ac70110) 91.43% compared to head (c4e9c1b) 91.41%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #463      +/-   ##
==========================================
- Coverage   91.43%   91.41%   -0.03%     
==========================================
  Files         245      245              
  Lines        7932     7932              
  Branches     1609     1609              
==========================================
- Hits         7253     7251       -2     
- Misses        461      463       +2     
  Partials      218      218              

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[viceroypenguin]

this also made me realise that you didnt go with cts.CancelAfter is it for performance reasons?

cts.CancelAfter() will always cancel the CTS. This means that you can't reuse the same CTS for every loop. You can't use .CancelAfter() and undo the cancellation if something happens that you wanted to happen.

[viceroypenguin]

Could you please rebase your branch off latest in viceroypenguin/SuperLinq? There are a lot of changes this branch is missing, which affects the codecov evaluation.

[julienasp]

Could you please rebase your branch off latest in viceroypenguin/SuperLinq? There are a lot of changes this branch is missing, which affects the codecov evaluation.

i'll push that, it should be good now

[viceroypenguin]

Thanks for adding the tests!