fix prototype solution in dependent minimist package #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
another (better) long term solution would be to update mkdir to the new 1.x versions as the old 0.5.x are (mostly) unsupported by now. |
|
thank you! i've merged #6 and released 1.0.3 with this change. feel free to open a PR with mkdirp update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please merge this PR to loosen the dependency on mkdir package to allow installation of the new version 0.5.3 that fixes its minimist dependency. Current version of minimist has a prototype pollution vulnerability (https://www.npmjs.com/advisories/1179 or https://app.snyk.io/vuln/SNYK-JS-MINIMIST-559764)
Afterwards please publish a new minor version to allow all other projects to pick up this fix (like eslint loader for vue)
Thanks,
Stefan Seide