Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSDK-9764 - fix special case of generics for user prompted modulegen #4728

Merged

Conversation

stuqdog
Copy link
Member

@stuqdog stuqdog commented Jan 18, 2025

Fixes issue with generic module generation failing from user prompts. cc @abe-winter @zaporter-work

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Jan 18, 2025
Copy link
Member

@abe-winter abe-winter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not my area, but ✔️ in case you just need a review to merge

@stuqdog stuqdog requested review from a team and njooma and removed request for a team January 21, 2025 14:35
@stuqdog stuqdog merged commit 0c04844 into viamrobotics:main Jan 21, 2025
17 checks passed
@stuqdog stuqdog deleted the fix-generic-modulegen-from-user-prompts branch January 21, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants