RSDK-9356 Bump timeout slightly for TestFirstRun/with_timeout #4706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://viam.atlassian.net/browse/RSDK-9728 causing CI failures; will look at that, too. |
Famous last words! |
dgottlieb
approved these changes
Jan 13, 2025
afc626c to
ce74f43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RDSK-9356
1ms timeout, as @dgottlieb diagnosed, was sometimes not enough time to actually let the first run script start, so we got did not get the expected error. Bumping to 100ms should definitely be enough time for the script to start while still not being a high enough value to allow
module/testmodule/first_run.shto complete (as it callssleep 1internally.)