-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Kustomize v5.0.0 #170
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@starcraft66 Thanks for making a PR! I love Starcraft 😁
Excited that there is a new kustomize release. Can you also update sigs.k8s.io/kustomize/api
to v0.13.0 in the go.mod file and run go mod tidy
?
We may also need to drop support for Go 1.18: kubernetes-sigs/kustomize#4877
That's awesome, glad to hear it! I do too obviously
I went ahead and did all of that, also fixed a couple unit tests that broke. |
@@ -10,6 +10,4 @@ metadata: | |||
# otherwise, path should be relative to manifest files, like | |||
# path: ../../../ksops | |||
files: | |||
# NOTE: File is relative to the /base manifest! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is actually a bug that was fixed in kubernetes-sigs/kustomize#4654
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! You're right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work. Thank you for contributing!
Kustomize 5.0.0 contains important fixes for loading remote resources and other stuff.