Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow open-ended ranges #17

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

maennchen
Copy link

@maennchen maennchen commented Mar 25, 2024

Handle empty and unbound ranges.

See:

@maennchen maennchen marked this pull request as draft March 25, 2024 15:42
@maennchen maennchen force-pushed the allow_open_ended_ranges branch from 6e4ee91 to c1a7886 Compare March 25, 2024 15:52
@maennchen maennchen marked this pull request as ready for review March 25, 2024 15:54
@vforgione
Copy link
Owner

@maennchen, really like what you've implemented here--thanks! I especially love the linked docs for reference.

Could you add a couple tests with non-:unbound/:empty values for either side of the bounds and issue queries to ensure compatibility? Assume this will work since it follows the postgrex spec.

After that, I'd be more than happy to merge this!

@maennchen
Copy link
Author

Replaced by #30

@maennchen maennchen closed this Oct 24, 2024
@maennchen maennchen reopened this Nov 30, 2024
@maennchen maennchen marked this pull request as draft November 30, 2024 17:04
maennchen and others added 2 commits November 30, 2024 18:19
Co-authored-by: Jonatan Männchen <jonatan@maennchen.ch>
@maennchen maennchen force-pushed the allow_open_ended_ranges branch from c1a7886 to 82fe6ec Compare November 30, 2024 17:29
@maennchen maennchen marked this pull request as ready for review November 30, 2024 17:29
@maennchen
Copy link
Author

@vforgione Rebased and incorporated tests from #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants