Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Select]: disabled with multiple can still be changed. #438

Closed
5 tasks done
Nalca opened this issue Nov 30, 2023 · 0 comments
Closed
5 tasks done

[Select]: disabled with multiple can still be changed. #438

Nalca opened this issue Nov 30, 2023 · 0 comments
Labels
bug Something doesn't work component New component request or issue about component

Comments

@Nalca
Copy link
Contributor

Nalca commented Nov 30, 2023

Describe the bug

Hello, nice library here !

While using it, I stumbled on a bug using the select component.
When the multiple, disabled and clearable prop are used together and with an initial selection, I can remove options (And of course, it update the binded values).

Since the component is disabled, users should not be able to change its values, or remove option.

Reproduction

https://playground.vexipui.com/#eNp9VW1v2zYQ/iuEOlQUZkttM2CYZxtrgwDd0L2gybcoUBTpbDGhSI6k/AJH/31HUrLdrC0QIOLdc8fnnrujD5HRVfZeqXTTQTSL5qbSTFliwHaK8FKsF3lkTR4tc8FaJbUlB6JhRXqy0rIlMYbFuchFJYWxZFPyDgxZOMhcdO0D6Nu7Jb19NyE/T8gvd8mvI1Iqy/ADoe+1Lvepy0YPhINY22ZG3r4j/YTQYkJYQhZLQg+5IMjnAfiM3P/tg8kPB0Z+JG/7+4lz+rtnxJty0SdJLuZZKAfJ48FCq3hpAU+EzNXystMaxEh6Rg6HkX/fzzMVYNfAobLuE2+YtrJGAh6FugR0HgVv23HLFIdwqpkpHzjU4VRxKLU7h2Moflo1UD0Fy6ySnbBTzlpmMfPFmHQ26IS24St4lvMsMEOW8+ysMjwau+dATCUV1GhJNzs1NR5MvIptuZtuWe1k/unNG7XDnvReKxeHAdEkCq2etqVKH40UOBg+Mh8cSALlwiD8Q7TFu8SKrV9gK9kqxkGHboWYUFUelZzL7R/eZnUHvoE+xknyFfuj2TlbHikNBvQG8ujos6Vegw3uq+u/YIffRyd2rEPZv+f8DEbyznEMsA+dqJH2Gc6z/d2XzsT6xlztLAgzFvUFUbtXbiRm5BbnA3ZMTTuWeWNap064O4fsPR4RHVx+R6VTZRfphY8bJXdb25ZMYEoU/LiZlQYcA1znCWn+t6JHFMMFxJJOgIEnogYMZhh86fg4nJw3DbRwvWW2ao6gM9sAHhf9MyiOW+5rEmWLGxo7U+wV8M8MTcaKNR61IGjAlW9oXLNNPCG3DUUOCZZEz65J7nDBR0XGy1q3RXhbyOCzBkeJBaGZbpmo5ZaUhpRin6RFgY6iQNdROerYJWlngA46uZfEZUJoOgw6aC31x9LPCQaDu81dJDkEHwXPzoV4TjR+hd8xGj1bAVvyD0rHDMw3ktVLSnGuJd/ABEV4xFV9WQCr8Z64KHyvCr+qRYEyj37JHaCWVdfim5b+24HehxcCydy/wqey7u8TV/jHmz8/fWLi6YqjlqjWMxEd56dMjXve8a7GWmVmWdYJ9bTGwttsnJPf3FtjbIZvnA2vRloZ43tOCFsR6si8fu04pSHbYuHTnjXaF0u9SGPfh3aemHBkiUxctufnU22hVQN9GjuUE9b/QOB3+m2pvFuDm8fY200DYE+uoXT37yyfFFyWLmeYqi+4DwDfc/+z53oXYo98GyjrFGcJtP0AK6mBuqjJC8CKaWMvG8ZrNyRJahsQ1M8OnqP+PzwAlRE=

Steps to reproduce

Go to the playground, then try removing an option by clicking on the close button of an option.

System Info

On the playground :
Vexip UI: 2.2.16
Vue: 3.3.4
Typescript: 5.2.2

Validations
@qmhc qmhc added bug Something doesn't work component New component request or issue about component labels Nov 30, 2023
@qmhc qmhc closed this as completed in 0ef5c2a Nov 30, 2023
qmhc added a commit that referenced this issue Dec 1, 2023
@qmhc
fix: correct disabled and readonly of form control components
f90b44d 
fix #438
qmhc added a commit that referenced this issue Jan 12, 2024
@qmhc
feat(video): add Video component (#426)
17f02cd 
* chore: create component

* wip: update

* wip: update

* wip: update

* wip: update

* wip: update

* wip: update

* wip: update

* wip: update

* wip: update

* wip: update

* revert:  re-adjust outline-color to outline

fix #433

* perf(tooltip): dynamically render popper element

* feat(ellipsis): add tip-shift prop

* chore(tooltip): effective unit tests

* fix(auto-complete): correct behavior when directly input

fix #434

* refactor(table): improve fixed columns implement and support column group (#435)

* wip: update

* feat: support column group

* docs: update demos

* docs: update apis

* chore: transfer to setup script

* wip: side padding

* fix: side padding

* chore: group no-ellipsis prop

* chore: group text-align prop

* chore: col resize

* chore: update

* chore(tooltip): effective unit tests

* chore: update

* chore: update

* release(hooks): v2.1.1

* release: v2.2.12

* fix(table): ensure tree table work with virtual

* feat(table): add formatter prop for column

* fix(select): correct composition behavior for filter input

* release: v2.2.13

* fix(table): incorrect treeExpanded initialization of rows

* chore(toast): transfer to use setup script

* feat(hooks): add watchPauseable util method

* chore(hooks): create test config

* fix(table): ensure correct row span for head cell when refresh

* feat(table): add refreshData api method

* feat(table): add data-filter prop

* chore(tree): transfer to setup script

* feat(tree): support only filter leaf nodes

* fix: normalize component inherit class name

* fix: normalize input-base components composition events

* chore: compatible composition end process

* feat(utils): flatTree add buildId option

* feat(utils): walkTree callabck add parent parameter

* refactor(tree): avoid invade data when parsing by tree structure

* feat(utils): add isIterable and mapTree methods

* feat(utils): add filterTree method

* feat(tree): add getTreeData and getFlattedData api methods

* release(utils): v2.6.0

* release(hooks): v2.2.0

* release: v2.2.14

* docs: update tree preset types

* release(scripts): v1.1.2

* feat(table): add no-transition prop

* feat(utils): async debounceMinor and debounceFrame

* fix(tree): unexcepted expanding state changed

* feat(native-scroll): async refresh and ensureInView methods

* feat(scroll): async api methods

* fix(native-scroll): no emit event when sync scroll position

* perf(scrollbar): remove overused throttle for move process

* fix(hooks): useVirtual support wrapper changed

* chore(virtual-list): using renderSlot to create items

* perf(table): improve table cell span computation

* fix(confirm): ensure api method work

* perf(table): improve performance of virtual scrolling (#436)

* wip: update

* wip: update

* wip: update

* wip: update

* fix(table): correct flatted structure after drop

* feat(table): support inherit provided config when using columns and summaries props

* chore(table): make unit tests pass

* feat(full-screen): provide inner place for transfer elements

* fix(tree): rename empty-tip prop to empty-text

* types: normalize transfer prop type for default config

* types: normalize MaybeRef type

* feat(message): add transferTo method

* feat(notice): add transferTo method

* feat(toast): add transferTo method

* feat(loading): add transferTo method

* feat(contextmenu): support target option

* feat(confirm): add transferTo method

* chore: ensure element be removed after destroy plugin

* release(utils): v2.7.0

* release(hooks): v2.2.1

* release(config): v1.3.1

* release: v2.2.15

* docs(table): remove non-existent prop api

* fix(table): correct tree render when using virtual (#437)

* wip: update

* fix: correct tree process

* ci: deploy docs when publish

* fix(table): rename helper methods by more accurate names

* feat(table): add ellipsis prop

* release: v2.2.16

* ci: extract deploy docs workflow

* chore(utils): export BITree tree array

* fix(table): correct compute and refresh cell height when using tree

* chore: transfer some components to setup script

* ci: adjust deploy docs workflow trigger

* chore: update README.md

* feat(tag): add disabled prop

* fix: correct disabled and readonly of form control components

fix #438

* fix(overflow): correct rest count when using suffix

* fix(select): ensure selected slot work with filter

fix #439

* chore: transfer some components to setup script

* feat(wheel): add no-transition prop

* release(utils): v2.7.1

* release: v2.2.17

* wip: control layout

* feat: switch to lucide

* docs: update

* docs: update

* chore: update

* chore: update

* wip: segments

* wip: update

* docs: update

* feat: add shortcuts

* docs: update

* test: update

* docs: update

* test: update

* chore: update lock file

* chore: update lock file

* chore: update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something doesn't work component New component request or issue about component
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Nalca @qmhc