Skip to content

Commit

Permalink
fix(checkbox): effective using control to check all
Browse files Browse the repository at this point in the history
fix #103
  • Loading branch information
qmhc committed Aug 4, 2022
1 parent b0c7991 commit 70a5bb2
Show file tree
Hide file tree
Showing 9 changed files with 11 additions and 19 deletions.
2 changes: 1 addition & 1 deletion components/checkbox/checkbox-group.vue
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ export default defineComponent({
function handleControlChange() {
// 在 group 层进行更新, 未选满则全选, 反之全不选
const allValues = Array.from(valueMap.keys())
const checked = currentValues.value.length === allValues.length
const checked = currentValues.value.length !== allValues.length
allValues.forEach(value => {
valueMap.set(value, checked)
Expand Down
2 changes: 1 addition & 1 deletion docs/demos/checkbox/group/demo.en-US.vue
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<CheckboxGroup v-model:values="values">
<CheckboxGroup v-model:value="values">
<Checkbox
v-for="item in items"
:key="item"
Expand Down
2 changes: 1 addition & 1 deletion docs/demos/checkbox/group/demo.zh-CN.vue
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<CheckboxGroup v-model:values="values">
<CheckboxGroup v-model:value="values">
<Checkbox
v-for="item in items"
:key="item"
Expand Down
2 changes: 1 addition & 1 deletion docs/demos/checkbox/layout/demo.en-US.vue
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<CheckboxGroup v-model:values="values">
<CheckboxGroup v-model:value="values">
<Row>
<Column>
<Checkbox control>
Expand Down
2 changes: 1 addition & 1 deletion docs/demos/checkbox/layout/demo.zh-CN.vue
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<CheckboxGroup v-model:values="values">
<CheckboxGroup v-model:value="values">
<Row>
<Column>
<Checkbox control>
Expand Down
8 changes: 2 additions & 6 deletions docs/demos/checkbox/total/demo.en-US.vue
Original file line number Diff line number Diff line change
@@ -1,13 +1,9 @@
<template>
<CheckboxGroup v-model:values="values">
<CheckboxGroup v-model:value="values">
<Checkbox control>
All
</Checkbox>
<Checkbox
v-for="item in items"
:key="item"
:label="item"
></Checkbox>
<Checkbox v-for="item in items" :key="item" :label="item"></Checkbox>
</CheckboxGroup>
<br />
values: {{ values }}
Expand Down
8 changes: 2 additions & 6 deletions docs/demos/checkbox/total/demo.zh-CN.vue
Original file line number Diff line number Diff line change
@@ -1,13 +1,9 @@
<template>
<CheckboxGroup v-model:values="values">
<CheckboxGroup v-model:value="values">
<Checkbox control>
全选
</Checkbox>
<Checkbox
v-for="item in items"
:key="item"
:label="item"
></Checkbox>
<Checkbox v-for="item in items" :key="item" :label="item"></Checkbox>
</CheckboxGroup>
<br />
values: {{ values }}
Expand Down
2 changes: 1 addition & 1 deletion docs/demos/checkbox/vertical/demo.en-US.vue
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<CheckboxGroup v-model:values="values" vertical>
<CheckboxGroup v-model:value="values" vertical>
<Checkbox
v-for="item in items"
:key="item"
Expand Down
2 changes: 1 addition & 1 deletion docs/demos/checkbox/vertical/demo.zh-CN.vue
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<CheckboxGroup v-model:values="values" vertical>
<CheckboxGroup v-model:value="values" vertical>
<Checkbox
v-for="item in items"
:key="item"
Expand Down

0 comments on commit 70a5bb2

Please sign in to comment.