Skip to content
This repository was archived by the owner on Jun 19, 2024. It is now read-only.

fix: avoid overflowing multiplications in draw_buffer #92

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

Gavin-Niederman
Copy link
Member

Describe the changes this PR makes. Why should it be merged?

This fixed a panic caused by a faulty check in screen::draw_buffer that occurs when the number of pixels the region being drawn to is larger than u16::MAX.

Additional Context

  • I have tested these changes on a VEX V5 brain.

Copy link
Member

@doinkythederp doinkythederp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to update the changelog because the screen api is unreleased. Also it looks like you put the changes under an old header.

@doinkythederp doinkythederp merged commit 5fe9a56 into main Feb 15, 2024
6 checks passed
@Gavin-Niederman Gavin-Niederman deleted the fix/screen-checks branch February 15, 2024 06:07
@doinkythederp doinkythederp added this to the 0.8.0 milestone Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants