This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7
refactor: ADI devices #61
Merged
Gavin-Niederman
merged 24 commits into
vexide:main
from
Tropix126:feat/adi-addrled-solenoid
Feb 12, 2024
Merged
refactor: ADI devices #61
Gavin-Niederman
merged 24 commits into
vexide:main
from
Tropix126:feat/adi-addrled-solenoid
Feb 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gavin-Niederman
suggested changes
Feb 12, 2024
Gavin-Niederman
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
scope:adi
Updates ADI support
semver:minor
Adds functionality in a backward compatible manner
type:enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes this PR makes. Why should it be merged?
LogicLevel
rather than bools for controlling digital devices.AdiSolenoid
, a wrapper overAdiDigitalOut
for actuating SMC pneumatic solenoids.AdiSwitch
, anotherAdiDigitalOut
wrapper that abstracts bumper switches and limit switchesAdiDigitalIn::new_press
, instead swapping it forAdiSwitch::was_pressed
.AdiLineTracker
for abstracting the EDR line tracker sensor.AdiPotentiometer
to return degrees rather than tenth degrees.AdiMotor
to match the smart motor APIs, having output/raw output getters/setters.AdiUltrasonic
to return centimeters for distance, allowing raw units to be read throughAdiUltrasonic::raw_distance
.AdiEncoder::value
toAdiEncoder::position
.Additional Context