fix: avoid overflowing multiplications in draw_buffer

vexide · Feb 15, 2024 · fcfc612 · fcfc612
1 parent e04bb07
commit fcfc612
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/packages/pros/src/devices/screen.rs b/packages/pros/src/devices/screen.rs
@@ -459,7 +459,8 @@ impl Screen {
             .into_iter()
             .map(|i| i.into_rgb().into())
             .collect::<Vec<_>>();
-        let expected_size = ((x1 - x0) * (y1 - y0)) as usize;
+        // Convert the coordinates to u32 to avoid overflows when multiplying.
+        let expected_size = ((x1 - x0) as u32 * (y1 - y0) as u32) as usize;
         if raw_buf.len() != expected_size {
             return Err(ScreenError::CopyBufferWrongSize {
                 buffer_size: raw_buf.len(),