Add http interfaces for flush and compaction #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins go |
|
Unit testing passed. |
wadeliuyi
reviewed
Jul 23, 2019
| resp_ = "Op should not be empty. Usage: http:://ip:port/admin?space=xx&op=yy"; | ||
| return; | ||
| } | ||
| if (schemaMan_ == nullptr || kv_ == nullptr) { |
There was a problem hiding this comment.
maybe can move this check to front of this function
whitewum
previously approved these changes
Jul 23, 2019
src/kvstore/NebulaStore.h
Outdated
| @@ -151,7 +151,9 @@ class NebulaStore : public KVStore, public Handler { | |||
| const std::string& configKey, | |||
| const std::string& configValue); | |||
|
|
|||
| ResultCode compactAll(GraphSpaceID spaceId); | |||
| ResultCode compactAll(GraphSpaceID spaceId) override; | |||
There was a problem hiding this comment.
compactALL sounds like compact all spaces
|
Unit testing failed. |
|
Unit testing passed. |
1 similar comment
|
Unit testing passed. |
whitewum
previously approved these changes
Jul 24, 2019
| resp_ = folly::stringPrintf("Error inside"); | ||
| return; | ||
| } | ||
| auto* space = headers->getQueryParamPtr("space"); |
There was a problem hiding this comment.
Could use headers->hasQueryParam to check whether the argument is setting ?
|
Unit testing passed. |
| } | ||
| auto* op = headers->getQueryParamPtr("op"); | ||
| if (op == nullptr) { | ||
| err_ = HttpCode::SUCCEEDED; |
There was a problem hiding this comment.
When some argument is missing, why not E_ILLEGAL_ARGUMENT ?
|
Unit testing failed. |
|
Jenkins go |
|
Unit testing passed. |
|
Unit testing passed. |
critical27
approved these changes
Jul 30, 2019
darionyaphet
approved these changes
Jul 30, 2019
whitewum
approved these changes
Jul 30, 2019
|
subtask of #724 |
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Mar 21, 2022
<!-- Thanks for your contribution! In order to review PR more efficiently, please add information according to the template. --> #### What type of PR is this? - [ ] bug - [ ] feature - [x] enhancement #### What problem(s) does this PR solve? Issue(s) number: close vesoft-inc#3309 Description: small fix and add annotation. #### How do you solve it? #### Special notes for your reviewer, ex. impact of this fix, design document, etc: #### Checklist: Tests: - [ ] Unit test(positive and negative cases) - [ ] Function test - [ ] Performance test - [x] N/A Affects: - [ ] Documentation affected (Please add the label if documentation needs to be modified.) - [ ] Incompatibility (If it breaks the compatibility, please describe it and add the label.） - [ ] If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).) - [ ] Performance impacted: Consumes more CPU/Memory #### Release notes: Please confirm whether to be reflected in release notes and how to describe: > ex. Fixed the bug ..... Migrated from vesoft-inc#4012 Co-authored-by: jakevin <30525741+jackwener@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.