-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable the bidirection edges. #3507
Disable the bidirection edges. #3507
Conversation
RETURN type(e) AS Type, e.start_year AS StartYear, e.end_year AS EndYear | ||
LIMIT 3 | ||
""" | ||
Then a ExecutionError should be raised at runtime: Scan vertices must specify limit number. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's confused to throw the scan vertices
error, It's obviously scan edge
in the query.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This plan start from ScanVertices, and transformed to ScanEdges in optimizer, but in this case transform failed, so result in ScanVertices failed.
Codecov Report
@@ Coverage Diff @@
## master #3507 +/- ##
=======================================
Coverage 85.19% 85.20%
=======================================
Files 1306 1307 +1
Lines 122158 122247 +89
=======================================
+ Hits 104078 104162 +84
- Misses 18080 18085 +5
Continue to review full report at Codecov.
|
RETURN type(e) AS Type, e.start_year AS StartYear, e.end_year AS EndYear | ||
LIMIT 3 | ||
""" | ||
Then a ExecutionError should be raised at runtime: Scan vertices must specify limit number. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error msg really confuses me. What's the correct way to write this sentence?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MATCH ()-[e:is_teacher]->()
RETURN type(e) AS Type, e.start_year AS StartYear, e.end_year AS EndYear
LIMIT 3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't allow the bidirection.
What type of PR is this?
What does this PR do?
Which issue(s)/PR(s) this PR relates to?
Close #3505
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context/ Design document:
Checklist:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: