Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support http2 (#278) #280

Merged
merged 2 commits into from
Aug 23, 2023
Merged

support http2 (#278) #280

merged 2 commits into from
Aug 23, 2023

Conversation

Sophie-Xie
Copy link
Contributor

pick #278

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2023

Codecov Report

Patch coverage: 37.50% and project coverage change: -0.64% ⚠️

Comparison is base (71a8713) 62.12% compared to head (278925f) 61.48%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
- Coverage   62.12%   61.48%   -0.64%     
==========================================
  Files           9        9              
  Lines        2305     2342      +37     
==========================================
+ Hits         1432     1440       +8     
- Misses        734      762      +28     
- Partials      139      140       +1     
Files Changed Coverage Δ
configs.go 38.73% <20.00%> (-0.69%) ⬇️
connection.go 55.81% <34.04%> (-11.54%) ⬇️
session_pool.go 61.07% <50.00%> (+0.11%) ⬆️
connection_pool.go 81.46% <62.50%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Nicole00
Nicole00 previously approved these changes Aug 8, 2023
@Sophie-Xie
Copy link
Contributor Author

hold, need to modify thrift.

Sophie-Xie and others added 2 commits August 23, 2023 10:49
* feat: support http2 (#246)

* update fbthrift (#255)

* fix conflicts

* remove ssl examples

---------

Co-authored-by: Vee Zhang <veezhang@126.com>
@veezhang
Copy link
Contributor

veezhang commented Aug 23, 2023

sed -i 's,github.com/facebook/fbthrift,github.com/vesoft-inc/fbthrift,g' `grep -rl github.com/facebook/fbthrift .`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants