[✅] ready for merge: starlark: add 'bytes' data type, for binary strings #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Agitolyev @aslepakurov I have minimized the changes to the absolute minimum to pass the specification so that we can contribute this upstream to https://github.com/bazelbuild/bazel. After reviewing this, feel free to contribute the patch upstream and to have a review from the Starlark team. You can see the relevant folks on this issue: bazelbuild/bazel#374. |
- byteliteral checkin update lexer to support byteliterals and escape sequences - lexer updated to match golang and can now parse byte prefixed strings - introduce string escapes - allow byte literals without using a ByteBuffer - Fix up the comments revert PythonBuiltins minimize the amount of changes from upstream more minimization of change remove third party folder as it adds noise to patch minimize diffs
aslepakurov
approved these changes
May 27, 2021
la-luo
pushed a commit
to la-luo/starlarky
that referenced
this pull request
Sep 8, 2021
…ngs (verygoodsecurity#115) * allow ScriptTest.java to run from libstarlark * starlark: add 'bytes' data type, for binary strings - byteliteral checkin update lexer to support byteliterals and escape sequences - lexer updated to match golang and can now parse byte prefixed strings - introduce string escapes - allow byte literals without using a ByteBuffer - Fix up the comments revert PythonBuiltins minimize the amount of changes from upstream more minimization of change remove third party folder as it adds noise to patch minimize diffs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes in release / Impact of release:
This change defines a 'bytes' data type, an immutable string of bytes. In this Java implementation of Starlark, ordinary strings use strings of UTF-16 codes for the ordinary string type, and thus need a distinct type for byte strings.
Documentation
Risks of this release
Is this a breaking change?
Is there a way to disable the change?
Additional details go here
Attempts to fix bazelbuild/starlark#112