fix: correct bucket name to fix broken -replication role (cloudposs…

…e#250)

* fix: fixes broken replication name

* fix: use local value

Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>

* fix: use bucket name from local

Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>

* fix(replication): missing quote, created local

---------

Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>

replication.tf

@@ -1,7 +1,11 @@
+locals {
+  replication_role = format("%s-replication", local.bucket_name)
+}
+
 resource "aws_iam_role" "replication" {
   count = local.replication_enabled ? 1 : 0
 
-  name                 = format("%s-replication", module.this.id)
+  name                 = local.replication_role
   assume_role_policy   = data.aws_iam_policy_document.replication_sts[0].json
   permissions_boundary = var.s3_replication_permissions_boundary_arn
 
@@ -28,7 +32,7 @@ data "aws_iam_policy_document" "replication_sts" {
 resource "aws_iam_policy" "replication" {
   count = local.replication_enabled ? 1 : 0
 
-  name   = format("%s-replication", module.this.id)
+  name   = local.replication_role
   policy = data.aws_iam_policy_document.replication[0].json
 
   tags = module.this.tags