Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation by up/down arrows #124

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

Navigation by up/down arrows #124

wants to merge 16 commits into from

Conversation

Happypig375
Copy link
Collaborator

@Happypig375 Happypig375 commented Jun 2, 2020 •
edited
Loading

Implements #54
Requires #117

@Happypig375 Happypig375 requested a review from charlesroddie June 2, 2020 09:53
@Happypig375 Happypig375 added the Aspect/Editor This is related to CSharpMath.Editor. label Jun 2, 2020
@charlesroddie
Copy link
Collaborator

@FoggyFinder are you able to review this officially? Both in the sense do you want to review this, and if you review this does it become mergeable? We've been fiddling with settings. Looks like we cannot request your review.

@Happypig375
Copy link
Collaborator Author

@FoggyFinder Are you interested in becoming a Collaborator?

@Happypig375
Copy link
Collaborator Author

@charlesroddie Only administrators (owners and collaborators) can be requested a review.

@Happypig375
Copy link
Collaborator Author

Nevertheless, #117 has to be merged first for the diff of this PR to only include work related to #54.

@FoggyFinder
Copy link
Collaborator

@FoggyFinder Are you interested in becoming a Collaborator?

I don't think I will be a good collaborator: in foreseeable future I can only review Prs and probably open PRs to close some small issues.
If this is OK then I will be glad to.

In any case I'll test & give feedback after #117 is merged.

@Happypig375
Copy link
Collaborator Author

I don't think I will be a good collaborator: in foreseeable future I can only review Prs and probably open PRs to close some small issues.

Collaborators can give approving reviews that enable merging. This is exactly what is needed - open PRs are accumulating without reviews.

If this is OK then I will be glad to.

Thanks

@Happypig375 Happypig375 requested a review from FoggyFinder June 9, 2020 15:58
@Happypig375 Happypig375 mentioned this pull request Jul 7, 2020
Merged
This was referenced Jul 14, 2020
Open
Open
@Happypig375
Copy link
Collaborator Author

This is a draft until #117 is done and merged back into this branch.

@Happypig375 Happypig375 marked this pull request as draft July 16, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesroddie charlesroddie Awaiting requested review from charlesroddie

@FoggyFinder FoggyFinder Awaiting requested review from FoggyFinder

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Aspect/Editor This is related to CSharpMath.Editor. Type/Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Happypig375 @charlesroddie @FoggyFinder