Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard coded line. #406

Merged
merged 7 commits into from
May 27, 2022
Merged

Remove hard coded line. #406

merged 7 commits into from
May 27, 2022

Conversation

Aryex
Copy link
Collaborator

@Aryex Aryex commented May 26, 2022

Summary

Fixed a hardcoded line of code that was added from #400 and was not addressed.

  • Added a new option to getWritePipe() and DSWriter() to fix the multiple connection issue. Again, this is not ideal and the code should be refactored.

Additional Reviewers

@alexey-temnikov
@alexr-bq
@jonathanl-bq
@jeremyp-bq

@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #406 (4db2247) into main (da8c329) will increase coverage by 0.39%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
+ Coverage   86.59%   86.99%   +0.39%     
==========================================
  Files          27       27              
  Lines        1731     1730       -1     
  Branches      110      110              
==========================================
+ Hits         1499     1505       +6     
+ Misses        232      225       -7     
Flag Coverage Δ
unittests 86.99% <80.00%> (+0.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...spark/datasource/v2/VerticaDatasourceV2Write.scala 77.77% <66.66%> (+7.50%) ⬆️
.../vertica/spark/datasource/core/DSConfigSetup.scala 87.75% <100.00%> (+1.36%) ⬆️
...a/com/vertica/spark/datasource/core/DSWriter.scala 95.45% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Aryex Aryex merged commit 0b84619 into main May 27, 2022
@Aryex Aryex deleted the fix_hardcoded_version branch May 27, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants