Fixed Header styles #126
Open
Fixed Header styles #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for find-me-issues-web-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
❌ Deploy Preview for find-me-issues failed.
|
|
Can you add a before and after screenshot to make it easier to understand what was changed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes the following changes:
Removed Box Shadow on Focus:
Added a CSS rule to remove the box shadow when an element is focused.
CSS Property Added: Header.css
.header__search--desktop:focus{
box-shadow: none;
}
Reason: This change is intended to streamline the focus state appearance and avoid any unwanted visual effects when the element is focused.
Added Padding with Bootstrap Class:
Added the Bootstrap class px-2 to provide padding and ensure consistent spacing.
Bootstrap Class Applied: Header.js
Reason: This adjustment is made to ensure that there is adequate spacing around the content, enhancing the overall layout and readability.
Please review these changes and let me know if there are any suggestions or modifications needed.