Issue #105: Fixed text color while hovering buttons on SingleCard #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for find-me-issues-web-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
❌ Deploy Preview for find-me-issues failed.
|
| @@ -98,6 +98,9 @@ const SingleCard = (props) => { | |||
| <Button | |||
| variant="outline-info" | |||
| onClick={() => setOpen(!openIssues)} | |||
| style={{ | |||
| '-webkit-text-stroke': '0.4px black' | |||
There was a problem hiding this comment.
are we sure about using webkit? Can it cause issues in any of the browsers?
There was a problem hiding this comment.
I was going by this:
This is on the containing div of the Card. Using WebkitTextStroke, shorthand for -webkit-text-stroke. Changing that to being black on the button using:
style={{'-webkit-text-stroke': '0.4px black'}}
It seems to work in all browsers I have tested.
Should I be looking elsewhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was setting an override for the button text:
WebkitTextStroke: "0.4px white",Left this code for the displaying the button as is. Added to the style of the button:
style={{'-webkit-text-stroke': '0.4px black'}}