-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve nightly test manual and regenerate QoR results #2895
Conversation
Just realized that I can just run the CI to see if it's working as intended. Started CI run just now; We should know if the changes are correct in ~16 hours. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AmirhosseinPoolad , thank you so much for cleaning this up and updating the golden results! I have some minor comments which should not change any functionality.
Could you please also set this test to be weekly. How about we have the workflow dispatch every week on Sunday Morning (so it will complete by Monday morning so we can resolve any issues if there are any):
- GitHub documentation: https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#schedule
- Example in our daily tests:
vtr-verilog-to-routing/.github/workflows/test.yml
Lines 22 to 23 in 7f0f9fc
schedule: - cron: '0 0 * * *' # daily
Leave a good comment with when this workflow should dispatch automatically and why.
I do not think these changes will change the workflow's functionality, so you do not need to test it again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
I will merge once CI passes. |
This PR changes the nightly test manual workflow to have different stages for each nightly test, making it easier to see at a glance which test went wrong.
I have also regenerated some results in nightly test 1 and 7. Since this was a very manual process, I could've made errors copying things around. Please double check to see if the golden results are for the correct tests and everything is okay about them.