[APPack] Added read_flat_place Option and Verifier #2861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaughnbetz
reviewed
Jan 17, 2025
Added the read_flat_place option to VPR's CLI. This allows the user to pass a flat placement file into the packer. Added code to parse this file into a FlatPlacementInfo object which only verifies that the atom given in the file exists in the atom netlist. Added code in the packer to read in the flat placement and verify that the flat placement is valid for use in the packer.
As per Vaughn's suggestions, added layer to the flat placement file specification to make it easier to upgrade to 3D FPGAs in the future. Fixed some small documentation issues.
19b2581 to
d3967a6
Compare
vaughnbetz
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Looks good. I suggest trying a bunch of broken files right now (2 things on a line, 8 things on a line, some atoms missing, some atoms duplicated, some atom names that don't exist, -ve x, -ve y, etc.). Doesn't have to be automated but worth trying right now.
Possibly you can add max val checks on x,y,layer and subtile when the device is not auto-sized, and could wrap them in a get_max_coord or some such function that keeps the code simple (returns +max_int or something if the device size isn't known yet).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the read_flat_place option to VPR's CLI. This allows the user to pass a flat placement file into the packer.
Added code to parse this file into a FlatPlacementInfo object which only verifies that the atom given in the file exists in the atom netlist.
Added code in the packer to read in the flat placement and verify that the flat placement is valid for use in the packer.