-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Packer] Greedy Clustering Candidate Selector Class #2856
[Packer] Greedy Clustering Candidate Selector Class #2856
Conversation
QoR results for
It looks like my machine was loaded while running the baseline; however, what is important is that it looks like we get the exact same minimum channel width, CPD, and WL. This implies that my refactoring of the packer had no changes to the output clustering. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Some suggested commenting updates, and some functional updates that can be deferred until after the initial merge. Should definitely get rid of (or create an issue for) the non-deterministic random number sequence when attraction groups are used.
Outlined all of the logic related to selecting a candidate molecule to pack into a given cluster into its own class. This class will maintain the information required for computing gains and selecting the highest gain molecule to pack. By separating out this logic, it makes it easier to modify and contribute to this code since it is now obvious where the code starts and where it ends. I have also went through and tried to modernize anything I could (for example, replacing C-style arrays for vectors). This code still needs a lot more cleanup, but this PR will be a good stepping stone for future refactorings.
3eb9eff
to
3defccf
Compare
Outlined all of the logic related to selecting a candidate molecule to pack into a given cluster into its own class. This class will maintain the information required for computing gains and selecting the highest gain molecule to pack.
By separating out this logic, it makes it easier to modify and contribute to this code since it is now obvious where the code starts and where it ends.
I have also went through and tried to modernize anything I could (for example, replacing C-style arrays for vectors). This code still needs a lot more cleanup, but this PR will be a good stepping stone for future refactorings.