Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update fracturable LUT connectivity based on known legal external placements #2668

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

KA7E
Copy link
Contributor

@KA7E KA7E commented Jul 29, 2024

Updated fracturable LUT connectivity in order to successfully reconstruct known legal clusters.

Description

Added complete interconnect from fracturable LUT data inputs to data inputs for each half LUT.

Related Issue

Motivation and Context

Unable to reconstruct known legal RippleFPGA-generated clusters without this change.

How Has This Been Tested?

Successfully reconstructed RippleFPGA solutions for all 12 ISPD benchmarks.

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@KA7E KA7E requested a review from vaughnbetz July 29, 2024 16:37
@vaughnbetz vaughnbetz merged commit 0fff441 into master Jul 29, 2024
36 checks passed
@vaughnbetz vaughnbetz deleted the ultrascale-connectivity-update branch July 29, 2024 19:46
@AlexandreSinger
Copy link
Contributor

@vaughnbetz One of the three PRs merged yesterday is causing vtr_reg_nightly_test5 to timout after 7 hours (it usually takes 3). I think this PR may be the culprit since this nightly test contains the vpr_ispd test and the other two PRs have nothing to do with vtr_reg_nightly_test5. Something seems to be causing these tests to take WAY longer than expected.

@KA7E
Copy link
Contributor Author

KA7E commented Jul 30, 2024 via email

@AlexandreSinger
Copy link
Contributor

@KA7E Thank you! I have raised a PR to undo this change so I can run the CI and see if it gets resolved:
#2670

I do not think it will be necessary to merge this reverting PR, but it will just verify if this is causing the issue. Perhaps this change makes the ISPD testcases a bit harder, and we may just need to move the ISPD tests into their own nightly_test.

@KA7E
Copy link
Contributor Author

KA7E commented Jul 30, 2024 via email

@vaughnbetz
Copy link
Contributor

Thanks. Reverting while investigating makes sense.
If necessary, we can make a different version of the ispd arch (ispd_flexible or some such) for the legalizer tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants