You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently: u is protected and so doesn't appear in the documentation, but the descriptions of its accessors/mutators refer to it. Now: these functions' descriptions don't reference u and state explicitly what they do.
Currently: there are duplicate descriptions for public pure virtual functions inherited from HeapInterface and/or KAryHeap. Now: only HeapInterface has descriptions for its public members (its inherited classes do not have any additional public functions).
Thanks!
There's one spurious CI failure: a single reg test of small designs with OdinII has a QoR failure. Probably was introduced in some prior PR and needs a golden solution update. Merging this, but if it persists it would be good if you can update the checked in golden results for it.
vtr_reg_nightly_test1_odin/arithmetic_tasks/FIR_filters_frac...[Fail]
2024-06-28T17:21:45.4560546Z �[32;1m17:21:45�[0m | [Fail]
2024-06-28T17:21:45.4562104Z �[32;1m17:21:45�[0m | k6_frac_uripple_N8_22nm.xml/fir_nopipe_26.v/common setup_TNS relative value 1.5002228616457025 outside of range [0.5,1.4] and not equal to golden value: -782.997
2024-06-28T17:21:45.4564196Z �[32;1m17:21:45�[0m | vtr_reg_nightly_test1_odin/arithmetic_tasks/multless_consts...[Pass]
2024-06-28T17:21:45.4565543Z �[32;1m17:21:45�[0m | vtr_reg_nightly_test1_odin/arithmetic_tasks/open_cores...[Pass]
2024-06-28T17:21:45.4566654Z �[32;1m17:21:45�[0m | vtr_reg_nightly_test1_odin/arithmetic_tasks/open_cores_frac...[Pass]
2024-06-28T17:21:45.4567883Z �[32;1m17:21:45�[0m | regression_tests/vtr_reg_nightly_test1_odin/power_extended_arch_list...[Pass]
2024-06-28T17:21:45.4569127Z �[32;1m17:21:45�[0m | regression_tests/vtr_reg_nightly_test1_odin/power_extended_circuit_list...[Pass]
2024-06-28T17:21:45.4570176Z �[32;1m17:21:45�[0m |
2024-06-28T17:21:45.4571064Z �[32;1m17:21:45�[0m | Test 'vtr_reg_nightly_test1_odin' had 1 qor test failures
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes to Router Heap documentation:
uis protected and so doesn't appear in the documentation, but the descriptions of its accessors/mutators refer to it. Now: these functions' descriptions don't referenceuand state explicitly what they do.HeapInterfaceand/orKAryHeap. Now: onlyHeapInterfacehas descriptions for its public members (its inherited classes do not have any additional public functions).