-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3D Placement Constraints #2623
3D Placement Constraints #2623
Conversation
The FASM unit test failure seems to be due to a change in the default layers returned for placement constraints on a 2D device: Updating the REQUIRE to pair(0,0) should work. @soheilshahrouz also tells me that if we make a custom printer class/method for std::pair catch2 will print objects instead of {?} in the failure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Half done ... getting slow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Should also add a region constrained case to one of our 3D architecture tests. Small design, A few different kinds of regions (multi-layer, single location, single location with subtile, etc.)
…le PartitionRegions are full instead of individual Regions
This PR enhances the supoort for 3D placement constraints to allow the user to specify a layer range for each floorplanning constraint.
Related Issue
Motivation and Context
Each floorplan constraint is limited to a single layer. If the user wants to define a cubic floorplan constraint, she/he has to define multiple rectangular floorplan constraint with the same (x,y) coordinates but for different layers. This PR lets user defne a single floorplan region spanning across multiple layers.
How Has This Been Tested?
Types of changes
Checklist: